search

kaltura / nginx-vod-module

NGINX-based MP4 Repackager
GNU Affero General Public License v3.0
2k stars 439 forks source link

Feature request: Control Closed Captions AUTOSELECT and DEFAULT Attributes #996

Open areeb111 opened 5 years ago

areeb111 commented 5 years ago

If you have a closed captions embedded in your HLS M3U8 File, nginx-vod-module treats the first source as the default and autoselected closed captions source, I hope if some one can make these as controllable attributes like the other mapped sources.

Example

#EXTM3U

#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="subs0",LANGUAGE="ar",NAME="Arabic",AUTOSELECT=YES,DEFAULT=YES,URI="http://xx.xx.com/vod/playlist_2_1557759526119771.json/index-f2.m3u8"

#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=3309855,RESOLUTION=1920x1080,FRAME-RATE=23.974,CODECS="avc1.640028,mp4a.40.2",SUBTITLES="subs0"
http://xx.xx.com/vod/playlist_2_1557759526119771.json/index-f1-v1-a1.m3u8

#EXT-X-I-FRAME-STREAM-INF:BANDWIDTH=188926,RESOLUTION=1920x1080,CODECS="avc1.640028",URI="http://xx.xx.com/vod/playlist_2_1557759526119771.json/iframes-f1-v1-a1.m3u8"

I have searched and found the source file building that which is : https://github.com/kaltura/nginx-vod-module/blob/45ce83bc86762b34bdd77c6ba5c03d2d40322874/vod/hls/m3u8_builder.c

erankor commented 5 years ago

I'm not clear on what you're asking - you want it to be AUTOSELECT=NO? or you want to be able to choose which one is the default when there are multiple?

areeb111 commented 5 years ago

Yes, I want it to be AUTOSELECT=NO,DEFAULT=NO In case of using only 1 closed caption file. But if this can be as an attribute like Language and Label then it would be much better.