kaltura / platform-install-packages

Official deployment packages to install the Kaltura platform on a server or cluster environments using native OS package managers
GNU Affero General Public License v3.0
520 stars 241 forks source link

kaltura-base-config.sh doesn't configure studio.ini on all frontend servers #516

Closed wzur closed 8 years ago

wzur commented 8 years ago

Hi there,

kaltura-base-config.sh configures studio.ini from kaltura-html5-studio properly only on the first frontend server, which has kaltura-html5lib installed.

This is due to the fact the script gets value of HTML5_LIB from kaltura-html5lib package version, and the installation instruction said that package should be installed only on one frontend server.

This leads to random problems with Studio in KMC if there are more than one frontend server behind a load balancer like AWS ELB, and when load balancer makes a query for studio.ini to a machine where that file hasn't been configured properly.

Waldemar

jessp01 commented 8 years ago

Hi @wzur,

You are most correct. See: https://github.com/kaltura/platform-install-packages/commit/535e200fe2ccb2c1aa8ba50f5ae64950f0bce895#diff-cf521aae9302d8796a8ed92e8d7ebf1eR308

kaltura-postinst-1.0.31-2.noarch.rpm already pushed to the 11.18.0 repo, which will become the stable version on Sun.

Thanks for reporting.

wzur commented 8 years ago

Hi @jessp01,

I don't see how this change is going to help. Maybe I'm missing something very obvious, but kaltura-front-config.sh still needs to run rpm -q kaltura-html5lib to get the version of the player, and that package is present only on one frontend server, thus leaving all other frontend servers without proper configuration.

jessp01 commented 8 years ago

HI @wzur,

The fix is to use: HTML5LIB_VERSION=`yum info kaltura-html5lib|grep Version|awk -F ":" '{print $NF}' instead of rpm -q kaltura-html5lib. This way, the retrieval of the latest version is done by querying YUM instead of the RPM DB. This means the html5lib package does not need to be installed on the machine running the script, whereas, when using rpm -q, it does.

Do let me know if I misunderstood your report.

Thanks,

wzur commented 8 years ago

Ah - yes - of course. So I just missed something very obvious as I suspected I did. I didn't notice yum instead of rpm.

Many thanks for a quick fix.

jessp01 commented 8 years ago

Most welcome and thanks again for reporting it.

May the source be with you,

Jess Portnoy

Kaltura Connect Virtual Summits 2015 - now on VOD! [connect.mediaspace.kaltura.com]

On Sun, 14 Feb 2016, wzur wrote:

Ah - yes - of course. So I just missed something very obvious as I suspected I did. I didn't notice yum instead of rpm.

Many thanks for a quick fix.

— Reply to this email directly or view it on GitHub.[AFBqvXjYrbzgKRN8HiKVPIEJlybKwM71ks5pkLcTgaJpZM4HXMzg.gif]

wzur commented 8 years ago

Hi @jessp01,

I just noticed both kaltura-base-config.sh and kaltura-front-config.sh query about kaltura-html5lib package and only the latter has been updated to use yum instead of rpm.

Do kaltura-base-config.sh need to check the version of that package at all?

Waldemar