search

kaltura / playkit-ios-dtg

Download-to-Go for iOS
GNU Affero General Public License v3.0
26 stars 12 forks source link

Crash app when download video hasn't data in manifest #57

Open sangnhh opened 4 years ago

sangnhh commented 4 years ago

Describe the bug A clear and concise description of what the bug is. When check audio manifest hasn't m3u8URL then crash app

To Reproduce Download a video has multi audio and subtitle Manifest file hasn't m3u8URL App is crashed

Expected behavior Check nil with a serveral cases hasn't data

Logs and Screenshots If applicable, add log and/or screenshots to help explain your problem.

Platform

Screen Shot 2020-03-11 at 2 26 47 PM

Additional context Add any other context about the problem here.

noamtamim commented 4 years ago

Please explain the case when a manifest doesn't have an m3u8 URL (give an example).

sangnhh commented 4 years ago

EXTM3U

EXT-X-VERSION:7

Created with Broadpeak BkS350 Origin Packager(version=1.9.5)

AUDIO groups

EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-aacl-128",NAME="Vietnamese",LANGUAGE="vi",AUTOSELECT=YES,DEFAULT=YES,CHANNELS="2"

EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-aacl-128",NAME="Korean",LANGUAGE="ko",AUTOSELECT=YES,CHANNELS="2",URI="player_test-audio_kor=128000.m3u8"

SUBTITLES groups

EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="textstream",NAME="Vietnamese",LANGUAGE="vi",AUTOSELECT=YES,DEFAULT=YES,URI="player_test-textstream_vie=1000.m3u8"

variants

EXT-X-STREAM-INF:BANDWIDTH=452000,CODECS="mp4a.40.2,avc1.4D4029",RESOLUTION=426x240,FRAME-RATE=30,AUDIO="audio-aacl-128",SUBTITLES="textstream",CLOSED-CAPTIONS=NONE

player_test-audio_vie=128000-video=297000.m3u8

EXT-X-STREAM-INF:BANDWIDTH=702000,CODECS="mp4a.40.2,avc1.4D4029",RESOLUTION=640x360,FRAME-RATE=30,AUDIO="audio-aacl-128",SUBTITLES="textstream",CLOSED-CAPTIONS=NONE

player_test-audio_vie=128000-video=533000.m3u8

EXT-X-STREAM-INF:BANDWIDTH=1182000,CODECS="mp4a.40.2,avc1.4D4029",RESOLUTION=854x480,FRAME-RATE=30,AUDIO="audio-aacl-128",SUBTITLES="textstream",CLOSED-CAPTIONS=NONE

player_test-audio_vie=128000-video=986000.m3u8

EXT-X-STREAM-INF:BANDWIDTH=2235000,CODECS="mp4a.

Example a manifest of me, it isn't enough m3u8 url field in audio group So when player detects audio which will crash Tks

sangnhh commented 4 years ago

Now my manifest formats EXT-X-VERSION version 7 Can you check this link https://developer.apple.com/documentation/http_live_streaming/about_the_ext-x-version_tag Tks

noamtamim commented 4 years ago

If I get this right, the issue is that this line:

#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-aacl-128",NAME="Vietnamese",LANGUAGE="vi",AUTOSELECT=YES,DEFAULT=YES,CHANNELS="2"

Doesn't have a URI (because it's the default, built-in audio stream). Can I get a working playback URL so I can reproduce the issue?

If you want, you can create a pull request, this will speed things up.

sangnhh commented 4 years ago

I give you link nondrm to test

noamtamim commented 4 years ago

I get 404 when I try to request this URL. Please provide a working URL. And like I wrote, if you think the fix is small - please create a pull request.

sangnhh commented 4 years ago

Vietnam VPN -> can play stream Other location -> stream 404 error Can you give me IP address to open VPN connection? Tks

sangnhh commented 4 years ago

Or Can you also give me your region?

noamtamim commented 4 years ago

@sangnhh I'm sorry it takes a long time to respond. These are crazy times.

Since you can easily reproduce the issue, it would help a lot if you can open a pull request and contribute the fix. Just make sure to sign the Kaltura CLA, otherwise we can't accept the code.