kaltura / sakai-extension

2 stars 7 forks source link

Plugin crashes the ckeditor #111

Closed jayee closed 6 years ago

jayee commented 6 years ago

The js error in the console: plugin.js?t=G87E:17 Uncaught TypeError: CKEDITOR.dialog.addIframe is not a function

The kaltura plugin uses CKEDITOR.dialog.addIframe which apparently is not supported in the mobile editor instance. I also tried upgrading the ckeditor to 4.7.3 with the same result.

This is tested with sakai 11.4 and kaltura sakai-extension 5.0.1.

kaltura-hooks commented 6 years ago

Hi @jayee,

Thank for you reporting an issue and helping improve Kaltura!

To get the fastest response time, and help the maintainers review and test your reported issues or suggestions, please ensure that your issue includes the following (please comment with more info if you have not included all this info in your original issue):

For general troubleshooting see: https://github.com/kaltura/platform-install-packages/blob/Jupiter-10.13.0/doc/kaltura-packages-faq.md#troubleshooting-help

If you only have a general question rather than a bug report, please close this issue and post at: http://forum.kaltura.org

Thank you in advance,

idodido commented 6 years ago

Hi @jayee

thank you for bringing it up - I have asked the team to take a look. For purposes of procedure, i would recommend sending future issues directly to our support team at customercare@kaltura.com. This will allow us to track any issue, and will allow the team to reply back in case any issues are need further investigation, and also allow us to make sure items are not lost.

if you would like to get updates on this issue, please contact kaltura customer case, and reference the following ticket ID: SAK-137.

Thanks, Ido

ern commented 6 years ago

See the following Sakai PR that disable plugins on a small devices https://github.com/sakaiproject/sakai/pull/1788

jayee commented 6 years ago

Hi @ern, the problem is that it is not usable in mobile view. We want it to work in mobile and that is why we added it to mobile view of ckeditor.

I don't know the status for SAK-137 @ kaltura

ern commented 6 years ago

Hi @jayee your issue is because in SAK-30370 they disabled all the plugins for devices under 800px if you remove this restriction and load the plugins this error will go away. Your issue is because the iframedialog plugin is not being loaded. See: https://github.com/sakaiproject/sakai/blob/3848c2b894e9a601fe43c8ed8acbd2580b2f87d2/library/src/webapp-filtered/editor/ckeditor.launch.js#L240

Again this is just a configuration issue where if you were to properly configure ckeditor to load the correct plugins it would work.

jayee commented 6 years ago

Thank you Earle!

We will look into enabling the plugins.

mån 5 feb. 2018 kl 15:20 skrev Earle Nietzel notifications@github.com:

Hi @jayee https://github.com/jayee your issue is because in SAK-30370 they disabled all the plugins for devices under 800px if you remove this restriction and load the plugins this error will go away. Your issue is because the iframedialog plugin is not being loaded. See:

https://github.com/sakaiproject/sakai/blob/3848c2b894e9a601fe43c8ed8acbd2580b2f87d2/library/src/webapp-filtered/editor/ckeditor.launch.js#L240

Again this is just a configuration issue where if you were to properly configure ckeditor to load the correct plugins it would work.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kaltura/sakai-extension/issues/111#issuecomment-363097813, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjxP5Jynm3NlbfIdKnn-3Nlzq0ZJR6Iks5tRw4wgaJpZM4QhzXH .