search

kaluginserg / cytoscape-node-html-label

Labels for cytoscape node. Demo:
https://kaluginserg.github.io/cytoscape-node-html-label/
MIT License
102 stars 43 forks source link

Doesn't call 'addOrUpdateElem' on data/style changes for removed nodes #58

Closed gaetanmaisse closed 3 years ago

gaetanmaisse commented 3 years ago

Currently, any change of data or style on a node ends up calling addOrUpdateElem, this causes issues with removed nodes as their HTML labels are added back to the DOM while they should not.

So I added a check to be sure the node isn't removed, from the underlying Cytoscape graph, before updating (or adding back) its HTML label.

Note: I'm not sure how the version bump + release is working so feels free to tell me if there are some missing things.

josejulio commented 3 years ago

Note: I'm not sure how the version bump + release is working so feels free to tell me if there are some missing things.

I'm not sure either. I would like to automate it and use some semantic release commit schema to automate the realeases and automatic bump. I did something like that on other repo and might take it here.

We should probably bump the patch as this is a bugfix (I can do that while releasing)

gaetanmaisse commented 3 years ago

I'm not sure either. I would like to automate it and use some semantic release commit schema to automate the releases and automatic bump. I did something like that on other repo and might take it here.

💪🏻 💯 I use conventional commit + semantic release on other repo and I do agree it's really awesome to not have to bother with the release anymore