Turn on elm-analyse - Githubissues

kalutheo / elm-ui-explorer

https://package.elm-lang.org/packages/kalutheo/elm-ui-explorer/latest

MIT License

215 stars 25 forks source link

Turn on elm-analyse #43

Closed leojpod closed 4 years ago

leojpod commented 4 years ago

While starting to use the explorer at works, I noticed a few elm-analyse warning here and there and thought I could make a quick PR to address them :)

summary:

create a github action that compile the project with elm and run elm-analyse
fix the warnings (and ignore the SingleFieldRecord ones)

kalutheo commented 4 years ago

hello @leojpod thanks for you contribution. In fact I was about to move from travis to github actions. So you pull request makes totally sense :) I'm going to merge it on the add-github-actions branch. I will let you know when it's on master

kalutheo commented 4 years ago

@leojpod merged on master 👍 thanks !!! 😄

leojpod commented 4 years ago

Nice! thank you and thanks for your elm-package it works great! I have it setup as a separate "main" with elm-live while the real app runs on a different port with create-elm-app and it works like a charm!

I've made a small adjustment to the source version to use elm-syntax-highlight so that my source tab shows elm code nicely :) would be happy to make it cleaner and make a PR for it if you think it useful.