created get end-points - Githubissues

kalviumcommunity / S61_SriKeerthi_Capstone_CalmCorner

This is your first repository

0 stars 1 forks source link

created get end-points #19

Closed srikeerthireddy closed 2 months ago

srikeerthireddy commented 1 month ago

@CodiumAI-Agent /review

CodiumAI-Agent commented 1 month ago

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the PR involves straightforward additions of GET endpoints in two route files. The changes are similar in nature and do not involve complex logic or large modifications.
🧪 Relevant tests	No
⚡ Possible issues	Inconsistent HTTP Status Code: The GET endpoints are using HTTP status code 201 (Created) which is typically used for POST requests that result in creation. For GET requests, a more appropriate status code would be 200 (OK).
🔒 Security concerns	No

Code feedback:

relevant file	Back-End/moodEntries/moodEntryRoutes.js
suggestion	Change the HTTP status code from 201 to 200 for the GET request, as 200 is the standard response for a successful HTTP GET operation. [important]
relevant line	res.status(201).json({message:"MoodEntries retrieved successfully"});

relevant file	Back-End/resources/resourcesRoutes.js
suggestion	Change the HTTP status code from 201 to 200 for the GET request to align with HTTP standards for retrieving data. [important]
relevant line	res.status(201).json({message:"Resources retrieving from the database",resources});