kalvn / Shaarli-Material

Shaarli Material is a theme for Shaarli, the famous personal, minimalist, super-fast, database free, bookmarking service.
https://github.com/kalvn/Shaarli-Material
MIT License
250 stars 23 forks source link

I've lost my FAB #117

Closed immanuelfodor closed 3 years ago

immanuelfodor commented 3 years ago

Hi, somewhere at or after the latest rewrite, my FAB button got lost, and I haven't found it since then. It's not in the DOM, so I don't think it's being blocked by a plugin. I've added a pinned post in my Shaarli to link to the Add Shaare form, this is how I circumvented this issue so far to be able to add new links from the web. Could you please check where did the FAB go? 😃

kalvn commented 3 years ago

If by FAB button you mean the button to add new links, yes, it's related to issue #118

I just need to get an alternative from Shaarli dev team and I'll publish a fix.

immanuelfodor commented 3 years ago

Yup, it's the Floating Action Button aka. FAB: https://material.io/components/buttons-floating-action-button :)

Thank you!

pascollin commented 3 years ago

In page.header.html $PAGE variable seems empty {$displayAddNewLinkIcon=(($is_logged_in || $openshaarli) && in_array($PAGE, array('linklist', 'tools', 'tag.cloud', 'tag.list', 'picwall', 'daily')))} Dirty workaround : replace this line by the following : {$displayAddNewLinkIcon=(($is_loggedin || $openshaarli))} Now the button is displayed on all pages when logged in.

immanuelfodor commented 3 years ago

It was previously fixed here, so this workaround is like a revert: https://github.com/kalvn/Shaarli-Material/issues/115#issuecomment-685266681

immanuelfodor commented 3 years ago

I've rebuilt my Shaarli using the support-v012 branch, and now the FAB is working again just as before. Thank you for the unnoticed changes in November :)