search

kalvn / Shaarli-Material

Shaarli Material is a theme for Shaarli, the famous personal, minimalist, super-fast, database free, bookmarking service.
https://github.com/kalvn/Shaarli-Material
MIT License
250 stars 23 forks source link

Remove the v prefix from the Shaarli version in the footer #125

Open immanuelfodor opened 3 years ago

immanuelfodor commented 3 years ago

The v prefix in the footer in front of the Shaarli version looks veird on the master branch build (vdev) and also violates the Semver scheme as it only consists of the X.X.X numbers.

Shaarli vdev - The personal, minimalist, super-fast, database free, bookmarking service by the Shaarli community - Documentation - Theme by kalvn

The default Shaarli template also doesn't have the v prefix there, please delete it :)

immanuelfodor commented 3 years ago

Mildly related to https://github.com/kalvn/Shaarli-Material/issues/124 as the server version is displayed there, too (not yet in Material).

kalvn commented 3 years ago

I'm not sure to agree with this point.

It doesn't violates the Semver scheme from my point of view. I don't consider the v is part of the version number itself. I just use it as a marker to indicate that what follows is the version number (even though it might seem obvious).

Of course vdev looks weird but it's initially not intended to appear on a production version. I agree that it's an issue for people who update their installation with git pull.

I'll think about this, but thanks for your feedback :)

immanuelfodor commented 3 years ago

I see, thanks for the thought behind it! I can completely accept it if you're optimizing for the latest release and not the master branch.

(However, sooner or later we will even have va38d25, v12abcd, and so on versions on the master branch, those will be fun 😃 https://github.com/shaarli/Shaarli/issues/1676 )

As a last resort, one can delete the v prefix from the footer when building a custom Docker image (sed -i -E 's/ v//' page.footer.html, the space is needed and the g flag can't be applied because of the space+value later in the file).

How about a config param that is set to v by default, and no need to include it in the config as visible option, however, one can set it to anything, even an empty string to disable the prefix.