Empty Slider and Lightbox Components create not needed void html tags

kalwalt / gatsby-starter-i18n-bulma

A gatsby multilanguage template with bulma and i18n: it is a work in progress...

https://gatsby-starter-i18n-bulma.netlify.app/

MIT License

23 stars 17 forks source link

Empty Slider and Lightbox Components create not needed void html tags #59

Open kalwalt opened 5 years ago

kalwalt commented 5 years ago

Reference here: https://github.com/kalwalt/gatsby-starter-i18n-bulma/pull/58#issuecomment-479912953

When i lightbox or a Slider component is empty a void section with a void div inside is created, it will be better if any html will be created, not sure if i will solve this specific issue in this PR.

kalwalt commented 5 years ago

i think i solved this creating dedicated templates for every page type, but i will it open until i will not be sure of this.