search

kalys / bamboo_ses

AWS SES adapter for Bamboo
MIT License
35 stars 24 forks source link

Feature/attachment headers #43

Closed jarrodmoldrich closed 1 year ago

jarrodmoldrich commented 3 years ago

Hi @kalys 👋

In a related PR to thoughtbot/bamboo I've exposed a variable in Bamboo.Attachment called :headers that can pass a number of arbitrary headers as a keyword list, permitting overrides of headers (e.g., Content-Disposition) or adding other special cases (e.g., X-Content-Id). The purpose is to give extra control to the library consumer, and the benefit for me, in particular, is to add inline image attachments that work well in a variety of email clients.

As well as these extra headers, there's a need to reorganize and wrap the inline attachments in a multipart/related part. I'll be pushing another related PR for that to DockYard/elixir-mail shortly, but I also duplicated the changes to the RFC2822Renderer module in this library. The update shouldn't regress any prior behavior, and I feel that the new code is appreciably more legible. From my testing, inline images now work properly in Outlook webmail with this change.

I haven't added anything to test suite yet, but will proceed to work on this PR if I have your blessing. So please let me know!

Cheers,

Jarrod

Related PRs: https://github.com/thoughtbot/bamboo/pull/631 https://github.com/DockYard/elixir-mail/pull/137

kalys commented 3 years ago

Hey @jarrodmoldrich.

Thank you for your contribution to the library.

Let's wait until your bamboo PR is merged.

jarrodmoldrich commented 2 months ago

@kalys I'm being asked to wrap up work on the related PRs, so just need you to remind me of one thing. Did you close this because you already added the functionality in another merge?

kalys commented 2 months ago

@jarrodmoldrich Yes. Since then I overhauled generation of the mail body. elixir-mail is not used anymore.

And content-id is supported. https://github.com/kalys/bamboo_ses/blob/master/test/lib/bamboo/adapters/content_raw_test.exs