Robust Bot Permit Comment Recognition

[0x4007]

We should parse the permit generation comments using URLSearchParams because we may add more URL search parameters to the URL in the future. Also the current approach is strict on the ordering of the parameters which seems brittle.

Yes, parsing the URL with URLSearchParams is a better approach

This PR solves the original issue + we don't have plans of adding more query params besides claim and network so I don't think that refactoring to URLSearchParams is an urgent issue

Besides, isn't it supposed to be https://pay.ubq.fi/?claim=

No, the generated URL is https://pay.ubq.fi?claim= so everything is fine

_Originally posted by @rndquu in https://github.com/ubiquity/ubiquibot/pull/508#discussion_r1265066358_

[0x4007]

This should be marked as a duplicate of #90

Reference: https://github.com/ubiquity/ubiquibot/issues/551

[kamaalsultan]

This should be marked as a duplicate of #90

Reference: ubiquity/ubiquibot#551

Hi, I did not run the bot yet. If you want to test, I can run it on my local. @pavlovcik

[0x4007]

Should be running serverlessly? Netlify?

[kamaalsultan]

Should be running serverlessly? Cloudflare worker?

I am not sure I got you correctly... The similarity work is done by the bot.

[kamaalsultan]

Could you comment what time is the most convenient for you so I can request for you comment? @pavlovcik

[0x4007]

Try running the bot serverlessly it's set up to work on Netlify.

[kamaalsultan]

Try running the bot serverlessly it's set up to work on Netlify.

It is working serverlessly... Unless I didn't get you wrong...

[0x4007]

The organization operates asynchronously. You should leave this running serverlessly so that the QA team can address on their own time (everybody is in different timezones.)

I'll be back testing pull requests when I have time and feel well tomorrow most likely.

[kamaalsultan]

Okay, got it Sure