kamalasv / orthanc

Automatically exported from code.google.com/p/orthanc
GNU General Public License v3.0
0 stars 0 forks source link

YBR_FULL are not decoded incorrectly #19

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Send an image with photometric interpretation = YBR_FULL into Orthanc
2. Access it via the /preview endpoint

What is the expected output? What do you see instead?
The image has a greenish tint to it - the rendering is not correct.  I did some 
debugging and the bug is actually in dcmtk in the file diybrpxt.h.  It is using 
the YCbCr formula and not the YBR formula.  I also checked the latest dcmtk 
source and it doesn't seem to be fixed there either.

What version of the product are you using? On what operating system?
Orthan 0.8.2 on windows

Please provide any additional information below.
There should be a way to get the raw / unmodified data for 7fe0,0010.  AFAIK, 
this is not possible so there is no way to workaround this bug other than 
getting the DICOM P10 file and parsing it myself.  I cannot share the YBR_FULL 
image I have and can't seem to find one online right now, I'll ask on 
comp.protocols.dicom

Original issue reported on code.google.com by cha...@gmail.com on 19 Sep 2014 at 2:52

GoogleCodeExporter commented 9 years ago
The title should be "YBR_FULL are not decoded properly".  so much for my english

Original comment by cha...@gmail.com on 19 Sep 2014 at 3:31

GoogleCodeExporter commented 9 years ago
Correction - upon further testing it seems the data is returned correctly from 
/content.  The problem is restricted to that of rendering the image via 
/preview.

Original comment by cha...@gmail.com on 19 Sep 2014 at 9:58

GoogleCodeExporter commented 9 years ago
Hello,

Thanks for reporting this issue!

Orthanc is not currently intended to handle photometric interpretations that 
differ from RGB and MONOCHROME2. I have just added a fix to prevent Orthanc 
from trying and decoding unsupported interpretations:
https://code.google.com/p/orthanc/source/detail?r=f5b0207967bcbd8f4cf36d6c32ece1
20373b2d80#

I have added a long-term task in Trello to ask the support of more 
interpretations:
https://trello.com/c/4Wx58bNG

Original comment by s.jodo...@gmail.com on 3 Nov 2014 at 2:22