kamalasv / orthanc

Automatically exported from code.google.com/p/orthanc
GNU General Public License v3.0
0 stars 0 forks source link

Hyphens seems to always trigger range query even if datatype does not support ranges #37

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
My case:

Accession number includes hyphens, but a query like this yields 0 results, but 
no error:

OrthancFindRequestHandler.cpp:265]   (0008,0050)  AccessionNumber = 
AB-1234-56789
OrthancFindRequestHandler.cpp:265]   (0008,0052)  QueryRetrieveLevel = STUDY

Replacing the hyphen with the ? wildcard yields the desired result:

OrthancFindRequestHandler.cpp:265]   (0008,0050)  AccessionNumber = 
AB?1234?56789
OrthancFindRequestHandler.cpp:265]   (0008,0052)  QueryRetrieveLevel = STUDY

Possibly related to issue #35

(Running version 0.9.0)

Original issue reported on code.google.com by vidar.l....@gmail.com on 9 Jun 2015 at 6:07

GoogleCodeExporter commented 9 years ago
You are right, Orthanc applies so-called "range matching" [1], even to VRs that 
are not date or time. But, "range matching is not defined for types of 
Attributes other than dates and times". This will be fixed.

[1] http://medical.nema.org/Dicom/2011/11_04pu.pdf (section C.2.2.2.5)

Original comment by s.jodo...@gmail.com on 10 Jun 2015 at 11:45

GoogleCodeExporter commented 9 years ago
Issue 35 has been merged into this issue.

Original comment by s.jodo...@gmail.com on 10 Jun 2015 at 11:47

GoogleCodeExporter commented 9 years ago
This is fixed in the mainline:
https://code.google.com/p/orthanc/source/detail?r=8e23f16a198d616e15ab3ad43c5489
1acdb67603

Original comment by s.jodo...@gmail.com on 10 Jun 2015 at 1:16

GoogleCodeExporter commented 9 years ago
Thanx :) Is it available as a binary dl anywhere yet?

Original comment by vidar.l....@gmail.com on 10 Jun 2015 at 1:46

GoogleCodeExporter commented 9 years ago
Unfortunately no, you'll have to build from source.

Original comment by s.jodo...@gmail.com on 10 Jun 2015 at 1:47

GoogleCodeExporter commented 9 years ago
Ok, Do you have any plans for an upcoming binary release in the nearest future?

If not, does building from source on windows have any quirks or issues I should 
know about?

Original comment by vidar.l....@gmail.com on 10 Jun 2015 at 2:27

GoogleCodeExporter commented 9 years ago
The build instructions for Visual Studio are available here:
https://code.google.com/p/orthanc/source/browse/INSTALL#56

Original comment by s.jodo...@gmail.com on 10 Jun 2015 at 2:42

GoogleCodeExporter commented 9 years ago
Confirming that bug is fixed after building from mainline.

Also: I was pleasantly surprised by how painless it was getting the build to 
run on my machine. As someone used to .net projects, with very limited 
knowledge about how C++ projects / builds function, I had 0 issues getting 
Orthanc to build on my windows machine. 

Thanks for responding so quickly, and keep up the good work.

Original comment by vidar.l....@gmail.com on 10 Jun 2015 at 6:12

GoogleCodeExporter commented 9 years ago
Thanks for your positive feedback! ;)

Original comment by s.jodo...@gmail.com on 10 Jun 2015 at 7:23