feat: :boom: Added more items to the in respect to issue #6

Omafovbe commented 2 years ago

Description Added images and data for more books and updated the cart function to source images from public directory. Also, dynamically add the items to the home component

This PR fixes #6

Having just a few items for display to add to cart
dynamically getting the image to display
a little change but spaced the cart text from the total number of items in cart
Notes for Reviewers

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
letsgoshop	✅ Ready (Inspect)	Visit Preview	Aug 21, 2022 at 3:55PM (UTC)

Omafovbe commented 2 years ago

Thanks for the comments.

The imgurl for now are the filenames of the image stored in the public folder and are referenced from home and cart component using JavaScript literal as thus .. images/${book.imgurl} which can be easily updated show Incase we need to pull the image from a remote url in the future
For the basketReducer.js firstly we need to get all of the items in the JSON file and that is why I made a find call to the item database with the action.payload arg. Apart from that every other code is consistent.

Thanks qgain

On Sat, 20 Aug 2022, 05:48 Kamal Nayan, @.***> wrote:

@.**** approved this pull request.

The changes have been very Impressive 🥇 just to look at these minor details.

In src/data/books.json https://github.com/legendarykamal/Lets-go-shop/pull/23#discussion_r950643130 :

@@ -0,0 +1,202 @@

+[

I appreciate this moving to a new .json file helps in simplifing 💯

In src/data/books.json https://github.com/legendarykamal/Lets-go-shop/pull/23#discussion_r950647819 :

},

{

"name": "JavaScript",

"tagName": "javascript",

"price": 15,

"imgUrl": "javascript.jpg",

"numbers": 0,

"inCart": false

},

{

"name": "jQuery",

"tagName": "jquery",

"imgUrl": "jquery.png",

how are these imgurl working ? without giving full http:.... url?

In src/reducers/basketReducer.js https://github.com/legendarykamal/Lets-go-shop/pull/23#discussion_r950648596 :
 switch(action.type) {
     case ADD_PRODUCT_BASKET:
productSelected = { ...state.products[action.payload]}

// productSelected = { ...state.products[action.payload] }

productSelected = { ...state.books.find(book => book.tagName === action.payload) };

This is wondurful to add the new logic but At all other places we are using action.payload as arg , just for consistency comment the new logic and uncomment the older one .

— Reply to this email directly, view it on GitHub https://github.com/legendarykamal/Lets-go-shop/pull/23#pullrequestreview-1079463944, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXP2H7SZY2XKGC7YFPCJUDV2BPTBANCNFSM57BXT3VQ . You are receiving this because you authored the thread.Message ID: @.***>