kamalem2000 / avr-uip

Automatically exported from code.google.com/p/avr-uip
0 stars 0 forks source link

lib timer32 definition error #26

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Error of definition between .c and header for timer32_set:
 * void timer32_set(struct timer32 *t, clock_time_t interval) in .h
 * void timer32_set(struct timer32 *t, clock_time32_t interval) in .c (good)

clock_time32() is not define (need a new file clock32.h ? add it in 
clock-arch.h ?)

timer_expired return an int, timer32_expired a bool:
 * consistency error
 * stdbool.h is not include in timer32.c

and last but not least the type of clock_time_t is defined in clock-arch.h and 
can be easily defined as a uint32_t, don't know if really necessary to do a 
"timer32" library.

Original issue reported on code.google.com by teppicymon@gmail.com on 9 Dec 2012 at 3:38

GoogleCodeExporter commented 9 years ago
Yea, I never did check in all of the 32 bit timer code from my workspace ;-\

I'll go fix it when I have a moment... things are  a bit busy at the moment.

Original comment by qarc...@gmail.com on 9 Dec 2012 at 6:51

GoogleCodeExporter commented 9 years ago
Oh, I see in the comments for change: r180  I hadn't tested or finished the 
timer32 code.

Original comment by qarc...@gmail.com on 9 Dec 2012 at 7:02