Closed goblin closed 10 years ago
Thanks for the report! Yes, I can reproduce this bug, but only with stereo flac files. In my testing, minimodem reads mono flac files (matching what it writes) just fine. Can you confirm that (a) your failure is with a stereo flac and (b) that you get proper results with a mono flac? The 'file' command will indicate whether your file is stereo or mono.
Thanks Kamal, yes, you're right, I only get this with stereo files. After throwing out one channel everything works fine :-)
In this case, perhaps a more graceful failure would be appreciated (i.e. just check if it's stereo at the beginning and if it is, print an error message and exit).
The crash is now fixed, as indicated below. Thanks again, goblin.
$ minimodem -f /tmp/stereo.flac -r 300
/tmp/stereo.flac: input stream must be 1-channel (not 2)
It would be nice if channels after the first were ignored and there was a warning about the ignored channels. In my use case, the audio files I am receiving have identical signals on the left and right channels.
I get segfaults when attempting to receive from flac files. Files were produced with minimodem and then played back over speakers, recorded to a mobile phone and then played back to a microphone (as a test). Unfortunately github doesn't allow me to include wave/flac files, but here's more or less what happens:
(...)
and here's what Valgrind shows:
I've compiled commit 3c227b516a0abd6daf1e1da82a12d3f20995625c from source.