kamalmostafa / minimodem

general-purpose software audio FSK modem
http://www.whence.com/minimodem
Other
846 stars 113 forks source link

Add parity support #12

Open aquila12 opened 9 years ago

aquila12 commented 9 years ago

Would it be possible to add support for even and odd parity on frames? At present, I need to work with 1-7-E-1 format frames. I suppose this would necessitate generating parity, which should be fairly straightforward (post-process the bits before sending to FSK), and checking parity, which would require handling frames with bad parity bits (I guess that they would either be dropped, or replaced with a character representing an error, e.g. '?'). If it was done in a reusable manner, so that parity could be added to other formats, that might be useful for others, too.

I'd be happy to assist in implementing this, but I thought it wise to determine the most appropriate place to do the extra processing first, and how others might suggest handling bad parity on received frames.