Several improvements and additions

[socram8888]

• First commit: adds an option to use "1" as start bit, and "0" as stop bit (the opposite of an standard UART)
• Second commit: uses 64 bit long longs instead of integers to store decoded bits. Neccessary for comms which use long packets which cannot be divided in smaller chunks.
• Third: adds the Cygwin result executable to .gitignore
• Fourth: generates expected bits strings outside of the main loop. By analysing the original code I noticed that only two different values were being used: one with the sync sequence, and another with data. Generating them outside the main loops not only improves performance, but also allows to specify custom leading sequences.
• Fifth: using long packets lengths yielded an error. Apparently the calculated buffer size was too small for anything over ~16 bits. I modified the code to employ the expected buffer size instead. For small packets no error was thrown actually because the "if" which checked if the buffer was too small to perform well resized it.
• Sixth: forgot to change a few variables which caused some results to get trimmed to 32 bits. Also undid some unnecessary changes.
• Seventh: adds decoding for UIC-751-3 (European ground-train-ground communications). It adds a MSB-first mode, which I thought I was going to need for UIC-751-3 but was actually not needed. I've left it anyway in case it is useful.

I have noticed no side-effects of these changes in any other modes. There may be some since I haven't checked it thoroughly.

[kamalmostafa]

Thanks very much, Marcos, for contributing your UIC-751-3 implementation!

As we have discussed elsewhere, all of these commits except for "Compute expected bit strings outside of main loop" (which breaks test cases and doesn't seem to be necessary for UIC-751-3) have now been merged into master, and will appear in the next minimodem release (version 0.21-1).

Your enhancement to minimodem is sincerely appreciated, Marcos. Thanks again!

[socram8888]

Well, thank you too for your awesome tool. It has been a pleasure to work with you! El 21/11/2014 00:04, "Kamal Mostafa" notifications@github.com escribió:

Thanks very much, Marcos, for contributing your UIC-751-3 implementation!

As we have discussed elsewhere, all of these commits except for "Compute expected bit strings outside of main loop" (which breaks test cases and doesn't seem to be necessary for UIC-751-3) have now been merged into master, and will appear in the next minimodem release (version 0.21-1).

Your enhancement to minimodem is sincerely appreciated, Marcos. Thanks again!

— Reply to this email directly or view it on GitHub https://github.com/kamalmostafa/minimodem/pull/2#issuecomment-63896638.