Fix configure script for non-Bash shells

kamalmostafa / minimodem

general-purpose software audio FSK modem

http://www.whence.com/minimodem

Other

854 stars 114 forks source link

Fix configure script for non-Bash shells #20

Closed Partmedia closed 8 years ago

Partmedia commented 8 years ago

The current configure script fails to work properly without CONFIG_SHELL=bash. This is the case on BSD, OS X, and Linux distributions that ship other shells as /bin/sh.

While here, remove unnecessary lines and use more idiomatic autoconf.

kamalmostafa commented 8 years ago

Hi Kevin- Can I ask you to split this into two commits, please?: One to fix the bash-isms, and another with all the whitespace and cosmetic changes. Thanks! -Kamal

Partmedia commented 8 years ago

I've split it up into two commits. Some cosmetic changes are in the first one because of how the hunks were split up. The bash-ism fix has to do with how deps_packages was constructed.

kamalmostafa commented 8 years ago

Merged. Thanks Kevin!