search

kamalmostafa / minimodem

general-purpose software audio FSK modem
http://www.whence.com/minimodem
Other
857 stars 114 forks source link

switch from Travis CI to GitHub Actions CI 💚 #47

Closed derhuerst closed 3 years ago

derhuerst commented 3 years ago

follow-up of #41

@ kamalmostafa Do you know why make fails under MacOS?

kamalmostafa commented 3 years ago

@ kamalmostafa Do you know why make fails under MacOS?

Looks like MacOS doesn't support the libsndio backend. I expect that adding "--without-sndio" to your macos ./configure step will fix it. I'll let you verify that, and will stand by for an updated PR. Thanks!

derhuerst commented 3 years ago

Looks like MacOS doesn't support the libsndio backend.

It worked on Travis CI before though. 🤔

kamalmostafa commented 3 years ago

Looks like MacOS doesn't support the libsndio backend.

It worked on Travis CI before though.

The libsndio backend was just committed to minimodem quite recently -- more recently than your earlier Travis CI testing, I think. When I committed it, I did wonder if it might break a MacOS build. Now we know! :-)

kamalmostafa commented 3 years ago

Oh @derhuerst also ... The minimodem --benchmarks step doesn't hurt anything, but isn't really relevant to the "build process"... However make check does run a bunch of "required-to-pass" self tests. How about adding a make check as a build step (or a post-build step or whatever is right)?

kamalmostafa commented 3 years ago

Very good! Thanks again for doing this, @derhuerst. Your diligence is much appreciated.