search

kamaradclimber / heishamon-homeassistant

An integration for heatpumps handled by heishamon
Apache License 2.0
48 stars 25 forks source link

Unable to set target temperature when using "Room Thermostat (Internal) - Weather Compensation" despite this being applicable in this mode #190

Closed teun95 closed 9 months ago

teun95 commented 9 months ago

Versions

Describe the bug My heat pump uses a compensation curve and uses the main remote control unit as thermostat (called "Room Thermostat (Internal) - Weather Compensation" in the manual).

The climate entity is displayed correctly, but the target cannot be changed from the thermostat card. This is because the climate entity has as attributes min_temp: -5 and max_temp: 5. Strangely enough, using climate.set_temperature the temperature can be set directly.

The attributes of climate.panasonic_heat_pump_main_z1_temp

hvac_modes: heat, off 
min_temp: -5 max_temp: 5 
target_temp_step: 1 
current_temperature: 18 
temperature: 19 
friendly_name: Aquarea Zone 1 climate 
supported_features: 1

To Reproduce Steps to reproduce the behavior:

  1. Switch heat pump to "Room Thermostat (Internal) - Weather Compensation"
  2. Attempt to increase or decrease the room thermostat target using the dashboard card

Expected behavior

I would expect to be able to change the target temperature of the room thermostat using the thermostat card as this the use of climate.set_temperature demonstrates that this is functional in my setup.

Screenshots

teun95 commented 9 months ago

A similar behavior was mentioned in a comment here by @archi, but the configuration described contained many more variables than my setup. Consequently the discussion might have focused on the emulation of the optional PCB, while this was unrelated to the cause. The setup in this issue does not use the optional PCB. I decided to open a new issue as the comment was not the same as the one described in the issue.

kamaradclimber commented 9 months ago

Hello, thanks for the clear report! I think https://github.com/kamaradclimber/heishamon-homeassistant/pull/167/files is in the right direction to fix the issue you encounter. Could you have a look and confirm? (the PR is not ready yet but close)

teun95 commented 9 months ago

I don't have the knowledge to evaluate whether the changes in the PR make sense, but I have changed my climate.py in HA to the one in the PR and the climate card and I can confirm that this fixes the issue. The climate card is now behaving as expected. Thanks for the work!

edit: Ah I now see that the PR is not ready yet. Oh well, I hope I don't run into any issues until it is ready and available in HACS :-)

kamaradclimber commented 9 months ago

I've put https://github.com/kamaradclimber/heishamon-homeassistant/releases/tag/1.7.0 in pre-release so you can install it with hacs (you need to accept "beta" releases). Don't hesitate to give more feedback!

teun95 commented 9 months ago

I have this (1.7.0 from HACS) running on two Home Assistant instances now with different heat pumps and I haven't run into any issues so far. Thanks for the fix! I think this issue can be closed.