search

kamaradclimber / heishamon-homeassistant

An integration for heatpumps handled by heishamon
Apache License 2.0
50 stars 25 forks source link

DHW value logic #30

Closed geduxas closed 2 years ago

geduxas commented 2 years ago

https://github.com/kamaradclimber/heishamon-homeassistant/blob/17e568b6d326f2e206ecc5c8ef4adc69abfa2b79/custom_components/aquarea/climate.py#L157-L172

For the 3 mode, I think would be best to switch off pump. If there is last option to heat DHW and you switch it off pump should turn off and that's it. vice versa and with room thermostats, if DHW is not installed and you switch off heating for all zones, pump should turn off.

PGnl commented 2 years ago

I think I get what you mean, but I believe that is not in line with normal logic. That is what the main switch on/off is for. I would be careful changing the logic of the heat pump in a standard setup. If this is really wanted, I would make “3” reliant on topic 100.

kamaradclimber commented 2 years ago

I am also not fond of switching off the pump altogether. Ill try to find a better way

geduxas commented 2 years ago

I am also not fond of switching off the pump altogether. Ill try to find a better way

Why not? If heatpump left only DHW heating option, and user for some reason desides to switch it off.. so nothing left to heat. Then logical step would be to turn off pump.. it could be combined with that switch.

and same behavior heating/cooling in zones. For example you have Heat + DHW in 2 zone settings. If you turn off DHW, you left with Heating only, if you turn off 1 zone, you left with heating and second zone only.. after turning off last zone, nothing left to heat.. so pump should turn off..

geduxas commented 2 years ago

I think I get what you mean, but I believe that is not in line with normal logic. That is what the main switch on/off is for. I would be careful changing the logic of the heat pump in a standard setup. If this is really wanted, I would make “3” reliant on topic 100.

Interesting what would be happened if you done this. Logically you can turn on /off DHW only while pump is in Off position.. and if you turn off pump while heating option left with DHW only.. and disable DHW.. what will happen after turning pump on? do anyone tried it before ? :)

PGnl commented 2 years ago

I would love to, but do not have DHW myself ;) Not sure how that would work.