kamatsuoka / goodtags

a tag app, but good
MIT License
6 stars 3 forks source link

Fix TypeScript errors and check types in CI #10

Closed FuegoFro closed 7 months ago

FuegoFro commented 7 months ago

This fixes errors discovered by yarn run tsc -- --noEmit (the last arg to skip outputting compiled files we don't care about) and adds that check to CI to keep the project clean. I was wondering why a type error in another change of mine wasn't caught, and this was the reason. In particular the export default from error in the async-storage.js mock seemed like a parse error that stopped it from discovering any other issues.

The fixes fall into a few categories: