kamatsuoka / goodtags

a tag app, but good
MIT License
7 stars 3 forks source link

[bug?] Non-favorited labeled tags #6

Closed thekugelmeister closed 2 months ago

thekugelmeister commented 9 months ago

In the current version of the app (v2.1.8), it is possible to add labels to non-favorited tags. This may be considered a bug or a feature, which may spark a larger discussion. However, there are seemingly unintended and undesirable consequences of this design as currently implemented.

How to reproduce

Very straightforward: just add a label to a tag without adding it as a favorite.

What happens

Upon selecting the label containing that tag from the menu drawer, the app goes to and highlights the Faves tab. It then displays all of the tags in that label, even the ones that are not Faves. As a result, when subsequently deselecting the label, the non-favorited tag counterintuitively disappears from the screen.

Thoughts/ideas

kamatsuoka commented 7 months ago

Thinking of

thekugelmeister commented 2 months ago

Updates to the current version seem to make the distinction between favorites and labels very clear! I'll close this as complete. Thank you!