kamax-matrix / mxisd

Federated Matrix Identity Server
GNU Affero General Public License v3.0
223 stars 115 forks source link

3PID Invitation lookups don't respect recursiveness settings #59

Closed maxidorius closed 6 years ago

maxidorius commented 6 years ago

When performing /store-invite, mxisd makes a lookup for a possible mapping, but recursive mode is hard-coded for ecosystem compatibility reasons. mxisd allows a full isolated system except for that hard-coded part.

While the rationale behind enforcing recursive lookups for invite still stands (not create an isolated island), it makes little sense to allow it in all the other modules but not in this one.

We should provide an option to disable recursiveness for invites and MUST label it as Danger zone or similar, so people understand the implications of doing so. We should also log warnings about it, so in case of debug/support, we are aware of it.

maxidorius commented 6 years ago

Fixed in #63