search

kamax-matrix / mxisd

Federated Matrix Identity Server
GNU Affero General Public License v3.0
224 stars 114 forks source link

small corrections for session.md #88

Closed stygianguest closed 6 years ago

stygianguest commented 6 years ago

So actually, I wanted to improve more of the actual content but I have to understand the material batter first. I will come back to it later.

maxidorius commented 6 years ago

Let me know when this is ready for review/merge

maxidorius commented 6 years ago

@stygianguest Any news on this? Should I expect further work?

stygianguest commented 6 years ago

@maxidor Sorry for the delay, had stuff to do and didn't get around this. I actually haven't been able to address the main problem, which is that I do not properly understand your definition of 'session'.

My intial impression is that a 'session' is the process by which a user binds a 3pid to a matrix identity. But the text seems to imply it means something slightly different, which I cannot lay my finger on exactly. It states, for example:

To ensure lookup works consistency within the current Matrix network, the central Matrix.org Identity Server should be used to store remote sessions and binds.

This, to me, seems to imply sessions are something tangible that can be stored. The subsequent notion of a session 'scope' reinforces my confusion.

If a session were indeed the process as I supposed from the start it cannot have a 'scope' in any traditional meaning of the word. Bindings on the other hand, clearly can have a scope. A session can then be started to create either a local or a remote binding, i.e., to create such bindings a session must be initiated with a local or remote identity server respectively.

If this interpretation is indeed correct, I'd be glad to reword the document to reflect that. I not, I would need some more explanation.

PS Perhaps it seems I'm getting too hung up on semantics here, but I assure you my confusion is genuine.

maxidorius commented 6 years ago

@stygianguest and now sorry on my side for my own delay. Given that more and more people seem to have an issue with the whole session, 3PID validation and overall federation concepts, I would like to revamp some sections as #98 of this doc along with #93 - this means I just merge this for the time being. Is that ok with you?