search

kamchatka-volcano / figcone

Read JSON, YAML, TOML, XML or INI configuration by declaring a struct
Microsoft Public License
100 stars 2 forks source link

Broken build because of dependency mismatch #21

Closed alexanderscheible closed 3 months ago

alexanderscheible commented 3 months ago

Hi,

first of all, thanks for the nice lib.

We have an issue building the lib. There seems to be a problem with a dependency to sfun and SealLake. In the following line sfun requires SealLake_OptionalSubProjects which is not found by the used seal_lake.

For the future, can you tag dependencies of figcone to specific commits/releases?

Unfortunately, we don't know when the error was introduced since we apparently used some cached version of the repo.

kamchatka-volcano commented 3 months ago

Hi, sorry for that( I mistakenly set the git tag of the sfun library to the dev branch in release 3.0.0. Currently, I'm working on updating seal_lake and was rolling it out on the dev branches of my projects, so sfun got updated and has broken the build. It should be fixed now, as I restored the previous state of the dev branch. I won't be updating it later and I'm going to lock it for changes; it will remain in the repo for compatibility with figcone v3.0.0.

can you tag dependencies of figcone to specific commits/releases?

Yes, I'm trying to. It was a stupid error. I'll consider making a pre-commit check that forbids using non-tag versions for dependencies on master branches of my projects.

alexanderscheible commented 3 months ago

Thanks for the quick response.

Unfortunately, it is still not working. Error msg: image (2)

Before your fix, we had a working state by replacing the unknown "SealLake_OptionalSubProjects" by "SealLake_OptionalBuildSteps".

kamchatka-volcano commented 3 months ago

Sorry, I wanted to fix it ASAP, so I rushed it out at the end of my lunch break and didn't try to build it. The dev branch of sfun was placed on the wrong commit. I fixed it now, so v3.0.0 should build fine. Please try again.

alexanderscheible commented 3 months ago

:+1: It is working again. Thanks