kamd / edscenicroute

Elite Dangerous: Scenic Route Finder web app
GNU Affero General Public License v3.0
5 stars 0 forks source link

Add in Codex Entries #5

Closed NoFoolLikeOne closed 2 years ago

NoFoolLikeOne commented 4 years ago

Hi I'm one of the R&D Boffins from Canonn Interstellar and I have an enhancement suggestion for you.

We have been capturing codex data from some time using our EDMC-Canonn plugin and I provide some dumps of our data in json format you can download.

https://drive.google.com/drive/folders/1663JAoDqpi9bnl9Mwf3xPsBTNymLStYx?usp=sharing

It would be amazing if you could integrate some of this data into your tool so we can route via codex entries as well as the GMP data that you already provide.

The data is updated every few hours so no need to download it very frequently.

Please let me know if you would be interested and if there is anything else I can provide to facilitate it.

kamd commented 4 years ago

Hi, that sounds like a good idea, this project was originally written before the modern in-game codex was a thing. They would probably be separate POI types to toggle on and off, glancing at the data they have some generic names and system/coordinate info, would there be anywhere useful to link to for further info like the current POIs have links to EDSM?

NoFoolLikeOne commented 4 years ago

Probably the best documentation would be to construct a search based on the name to the elite wiki https://elite-dangerous.fandom.com/wiki/Special:Search?query=Albidum+Sinuous+Tuber

Or you can do a search on the Canonn Website.

I could enhance the data to add a URL if that would help. I can add them to my reference data and pick the most appropriate locations.

kamd commented 4 years ago

That would indeed help, gives some information for those who don't know what tubers etc. are (plus I already have a place for the button in the UI 😉).

NoFoolLikeOne commented 4 years ago

OK. i'll see if I can get that done and will come back when its ready

NoFoolLikeOne commented 4 years ago

Working through it now. It just occurred to me that the the codex dump is non-unique per system/entryid. Is that going to be a problem? I guess you would prefer a unique dump by system name?

kamd commented 4 years ago

It's not a big problem for me to just ingest unique entries by (name,system) and ignore the duplicates. Also, because there are so many with the same names, they won't be selectable by name as destinations, only show up as en route POIs.

NoFoolLikeOne commented 4 years ago

Oh well I did it anyway. It wasn't a big deal and it meant I could tailor the data a little to exclude some stuff you don't need.

Let me know if this file works for you

https://drive.google.com/file/d/1avd-s4paXbZWPkXJCLI3XRP6SkQUNI1N/view?usp=sharing

kamd commented 4 years ago

Thanks, just been tinkering around with it, my script blew up on this entry however:

{"system": "Raxxla", "x": "-1807.43750", "y": "174.84375", "z": "-1058.50000", "entryid": 9999999999, "name": null, "category": null, "sub_category": null, "hud_category": null, "english_name": null, "url": "https://canonn.science/?s=None"},

Can I assume this is a joke entry as I am unaware of any recent breakthroughs in the field of Raxxla study, and do I need to be concerned for the veracity of the rest of this data? :stuck_out_tongue:

NoFoolLikeOne commented 4 years ago

One other thing.. Compressed or uncompressed?

NoFoolLikeOne commented 4 years ago

Looks like someone was having a bit of fun. I'll delete that also filter out the stuff farmed from EDSM

kamd commented 4 years ago

Compression doesn't matter all that much for this quantity of data, if pressed I have a small preference for gzipped data as that is what EDSM systems are currently exported as.

I don't have a lot of time to work on this, but it's coming along, likely be a week or two. I'll let you know when it's live.

kamd commented 3 years ago

OK, sorry it's a while later than predicted, but it's now live with that data mapped to the last two filter icons. They are off by default because there are so many, but clicking them enables them. 🎉

The code has support for showing body, latitude, and longitude when supplied in the data, if you were minded to update your finely crafted JSON file to include those - it makes sense to be able to actually find planetary POIs! Also, is there a stable link for edscenicroute.json.gz to be downloaded from programmatically?

NoFoolLikeOne commented 3 years ago

Adding body, latitude and longitude would increase the data a great deal as systems often contain many bodies with many signals. It might be better to provide a link tho this page which will show you what is there https://tools.canonn.tech/signals?system=Merope

The following url should work for downloading the raw file. It looks like google is trying to make accessing stuff harder and they no longer provide CORS support, so you won't be able to download from javascript if that is what you were hoping to do.

https://drive.google.com/uc?id=1avd-s4paXbZWPkXJCLI3XRP6SkQUNI1N