メッセージについてるスタンプを表示

kamecha commented 3 months ago

Close #103

Summary by CodeRabbit

New Features
- Enhanced message body representation with detailed stamp information.
- Added functionality for asynchronous retrieval of user and stamp data.
- Introduced options for improved text folding in the Vim configuration.
- Added benchmarking utility to assess message retrieval performance and caching strategies.
Bug Fixes
- Improved handling and display of stamp data in the plugin.

kamecha commented 3 months ago

めちゃ重いから、なんとか対処する

スタンプのキャッシュを用意する
- denops側 or バッファ変数のどちらかにしたい
スタンプ取得タイミングを変更する
- 折りたたみで隠れる箇所も描画しないといけないのかどうか気になる

coderabbitai[bot] commented 3 months ago

Walkthrough

The updates significantly enhance the traqvim plugin by improving how message stamps are represented and managed. Notable changes include a refined message body that integrates detailed stamp information and the introduction of asynchronous methods for retrieving user and stamp data. Additionally, Vim configurations have been updated to support better text folding, leading to an improved user experience when navigating message content.

Changes

Files	Change Summary
`autoload/traqvim/view.vim`	Enhanced `make_message_body` to include formatted message stamps; added `folded_stamp_text` function for unique stamp identifiers.
`denops/traqvim/main.ts`	Introduced `getUser` and `getStamp` methods for asynchronous retrieval of user and stamp data.
`denops/traqvim/model.ts`	Added asynchronous `getStamp` function for fetching stamp data by `stampId`, with caching improvements for efficiency.
`ftplugin/traqvim.vim`	Configured `foldmethod` to `marker` and set `foldtext` to `traqvim#view#folded_stamp_text()`.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Denops
    participant View

    User->>Denops: Request to get user data
    Denops->>Denops: Validate userId
    Denops->>User: Return user information

    User->>Denops: Request to get stamp data
    Denops->>Denops: Validate stampId
    Denops->>View: Fetch stamp details
    View->>Denops: Return stamp information
    Denops->>User: Return stamp data

Assessment against linked issues

Objective	Addressed	Explanation
スタンプ名, 押された合計回数, 押した人とその回数のASCII表示 (#103)	✅
折りたたみをうまく使いたい (#103)	✅

Poem

In the burrow where I play,
Stamps now bloom in bright array,
With names and counts that dance so high,
As folds of magic catch my eye.
Oh, what joy these changes bring,
A hopping tune, I want to sing! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

kamecha commented 2 months ago

試しに直近のgeneralを取ってきて、そこのスタンプとそれに紐づくユーザーを取るベンチを取ってみたらこんな感じになった同じ人が複数のスタンプを押すケースが多くて、ユーザーのキャッシュがかなり効きそう

kamecha commented 2 months ago

試しに直近のgeneralを取ってきて、そこのスタンプとそれに紐づくユーザーを取るベンチを取ってみたらこんな感じになった同じ人が複数のスタンプを押すケースが多くて、ユーザーのキャッシュがかなり効きそう

これのベンチはdenopsインスタンス経由してないから、実際とはちょっと違うの注意！

denops-testみたくdenops-benchみたいなのちょっと欲しくなっちゃうわね

kamecha / traqVimPractice