search

kamegami13 / MonsterHunter4UDatabase

MIT License
114 stars 41 forks source link

Draw Sharpness Procedurally #7

Closed jaysondc closed 9 years ago

jaysondc commented 9 years ago

Draw sharpness works now. On higher DPI devices the entire drawable should be 500x50px max, but should scale down on lower DPI.

The assumption at the moment is that the maximum sharpness possible is 50 units. nexus 6 detail nexus 6 list nexus s detail nexus s list

kamegami13 commented 9 years ago

I'll check this out when I get home in an hour or so. Looks really awesome. Out of curiosity what did you use for test data?

jaysondc commented 9 years ago

The existing database has sharpness data from MH3U that works fine. It's in the weapons table under sharpness. The format is "1.2.3.4.5.6.7 1.2.3.4.5.6.7" where each integer is the sharpness value for a particular color. Is the 4U sharpness data similar?

kamegami13 commented 9 years ago

https://docs.google.com/document/d/1DFWcsKCllUAjaCq8v5ykwNm7bZsDx1uDcJmW_GCMD0Q/edit

I changed it to a separate column for each color. I'm guessing that would be a simple change on your own. I'm assuming these match the Wikia sharpness from 3U?

On Fri, Feb 13, 2015 at 3:07 PM, jaysonthepirate notifications@github.com wrote:

The existing database has sharpness data from MH3U that works fine. It's in the weapons table under sharpness. The format is "1.2.3.4.5.6.7 1.2.3.4.5.6.7" where each integer is the sharpness value for a particular color. Is the 4U sharpness data similar?

— Reply to this email directly or view it on GitHub https://github.com/kamegami13/MonsterHunter4UDatabase/pull/7#issuecomment-74326981 .

jaysondc commented 9 years ago

Yea the data was correct. If you have the data I'd prefer it to be in the String format because there is there are already adapter methods to grab that data from the table. I'm fine either way.

kamegami13 commented 9 years ago

That would actually be a simple conversion in excel TBH. So sure we can do that. I actually never bothered to check if the 3U sharpness data was at all accurate or well formatted.

On Fri, Feb 13, 2015 at 3:28 PM, jaysonthepirate notifications@github.com wrote:

Yea the data was correct. If you have the data I'd prefer it to be in the String format because there is there are already adapter methods to grab that data from the table. I'm fine either way.

— Reply to this email directly or view it on GitHub https://github.com/kamegami13/MonsterHunter4UDatabase/pull/7#issuecomment-74330060 .

kamegami13 commented 9 years ago

Oh, quick thought. Does it handle malformed input without crashing?

jaysondc commented 9 years ago

No, right now it's looking for that specific formatted string. Should I be worried about that?

kamegami13 commented 9 years ago

I'd prefer if it logged an error and returned a blank sharpness bar or something. Basically I'd prefer if all our code logged an error and handled it without throwing an exception to avoid crashes. On Feb 13, 2015 8:59 PM, "jaysonthepirate" notifications@github.com wrote:

No, right now it's looking for that specific formatted string. Should I be worried about that?

— Reply to this email directly or view it on GitHub https://github.com/kamegami13/MonsterHunter4UDatabase/pull/7#issuecomment-74358687 .

jaysondc commented 9 years ago

Sure I'll try to implement that this weekend.