search

kamermans / guzzle-oauth2-subscriber

OAuth 2.0 Client for Guzzle 4, 5, 6 and 7 with PHP 5.4 - PHP 8.0 - no more dependency hell!
MIT License
140 stars 31 forks source link

Incorrect namespaces in OAuth2Handler #12

Closed kurakin-oleksandr closed 6 years ago

kurakin-oleksandr commented 6 years ago

in OAuth2Handler:

public function __construct(
                    GrantType\GrantTypeInterface $grantType,
                    GrantType\GrantTypeInterface $refreshTokenGrantType = null,
                    Signer\ClientCredentials\ClientCredentialsSigner $clientCredentialsSigner = null,
                    Signer\AccessToken\AccessTokenSigner $accessTokenSigner = null
    ) {

namespaces Signer\ClientCredentials\ClientCredentialsSigner and Signer\AccessToken\AccessTokenSigner are incorrect.

As workaround can be used setters.

kamermans commented 6 years ago

Thanks for the report! This is already fixed in the latest version. Are you able to confirm that it is working as expected?

kurakin-oleksandr commented 6 years ago

Yes, in latest version it is fixed. But I use v1.0.4 which is the latest stable version

kamermans commented 6 years ago

Ah, that's the issue then - I'll make another stable release after I review the changes and the test suite coverage today!

kurakin-oleksandr commented 6 years ago

thanks!

kamermans commented 6 years ago

I have released v1.0.5 stable: https://packagist.org/packages/kamermans/guzzle-oauth2-subscriber#v1.0.5

Let me know if you have any other issues, otherwise I'll assume this issue is resolved!