kami-blue / client

ARCHIVED - KAMI Blue: a continuation of 1.12.2 KAMI
https://kamiblue.org
GNU Lesser General Public License v3.0
360 stars 379 forks source link

Smooth outlines for shader ESP #1571

Open omninope opened 3 years ago

omninope commented 3 years ago

Is your feature request related to a problem? Please describe. No, it is an enhancement suggestion for the shader mode of the ESP module because it's not 100% perfect yet. Of course all of this is opinion based but just ignore this fact and continue reading.

Describe the solution you'd like The ESP outlines are quite blocky when using shader mode, some smoothing of them would be a nice additon. That's basically what I suggested for KAMI on issue 270 of their repo, and 086 marked as "help wanted" which makes me think this may be a little bit difficult. Below is a comparison as an example, from a close range it looks mostly fine but far away it's possible to really see the difference between a smooth and a blocky ESP.

KAMI Blue v1.1.7-beta - See, the shader outlines aren't smooth in any way. 2020-11-10_20 44 31 2020-11-10_20 59 37

Xulu v1.5.2 - Outlines are very smooth. This is much better. 2020-11-10_20 43 25 2020-11-10_20 58 47

Ignore the thickness of the ESP outlines, this is just so you can clearly see them in this example, and thinner outlines also make the effect worse. When in movement it's even worse. Xulu was used for the example because there is a safe (I really hope it is) free version, but of course there are other utility mods that also have a smooth outline, mostly paid, like RusherHack, Future and probably others. For some reason I tried programming this, but after spending way too many days searching how this works I did the smart thing and just gave up.

Describe alternatives you've considered Using the shader ESP as is or use the other ESP modes.

Additional context PLEASE do the same thing to #1161 when someone finds time to code that.

Luna5ama commented 3 years ago

Get Optifine and turn on FXAA

5HT2 commented 3 years ago

rofl

omninope commented 3 years ago

Get Optifine and turn on FXAA

I don't know if this was a joke since I lack most of the ability to understand jokes, but since this was something really simple I did it anyways. The results are: 2020-11-10_21 46 28 The outlines get a weird "noise" in them. This is honestly worse than without FXAA.

Side note: I tried just enabling Optifine's Antialiasing option and that gave a black screen that cannot be fixed by resizing, so I will make a issue for that.

Luna5ama commented 3 years ago

Get Optifine and turn on FXAA

I don't know if this was a joke since I lack most of the ability to understand jokes, but since this was something really simple I did it anyways. The results are: 2020-11-10_21 46 28 The outlines get a weird "noise" in them. This is honestly worse than without FXAA.

Side note: I tried just enabling Optifine's Antialiasing option and that gave a black screen that cannot be fixed by resizing, so I will make a issue for that.

Wtf how does it causes noises Also Optifine Antialiasing option (Not the FXAA) isn't compatible with shader as what the setting description says. So just ignore that.

omninope commented 3 years ago

Possibly not relevant but I tested with Xulu + Optifine with FXAA and there was absolutely no noise. Also, I tought Optifine's antialiasing was incompatible just with Optifine's shaders. Apparently I was very wrong and it is any shader loaded.