kami-blue / client

ARCHIVED - KAMI Blue: a continuation of 1.12.2 KAMI
https://kamiblue.org
GNU Lesser General Public License v3.0
361 stars 378 forks source link

Boss Stack wither names #1638

Closed 5HT2 closed 3 years ago

5HT2 commented 3 years ago

Created by: Muppet (512003165416325120)

An option in bosstack that reverts either names to 'Wither' on the client. I like seeing withers around me but don't like the hate speech.

FriedrichM commented 3 years ago

ill do this. For stack mode: do we want to keep the stack and have all of them say Boss or do we want to have one stack named Boss with the sum of all stacks?

We don't differentiate between bosstypes, in vanilla there are only ender dragons and withers but servers can create a few more colored bossbars if they want. (see BossInfo.Color)

Because of this id suggest just putting them together to one bar named Boss that is colored the same as the closest boss's Bar would be colored when CensorNames is on.

FriedrichM commented 3 years ago

the BossBar objects dont contain any information about the boss type btw.

5HT2 commented 3 years ago

do we want to have one stack named Boss with the sum of all stacks

I think that's what they want, yes

Luna5ama commented 3 years ago

Just count the boss from loaded entity. Display health for the closest one for each type.

FriedrichM commented 3 years ago

Bossbars can theoretically exist without entites. If I just count bosses for each type in the loaded entities I will ignore the Bossbars which were added by server mods. The question is do we care for such servers as this is an anarchy client and extra Bossbars are more of a rpg-server thing?

If we do not care, I could create the Bossbars entirely from the loaded entities instead of from the SPacketUpdateBossInfo and thus also differentiate between bosstypes in the normal stack mode. (atm a ender dragon and a wither named the same will stack)

the alternative would be as mentioned above to have one stack named Boss with the sum of all stacks

5HT2 commented 3 years ago

The question is do we care for such servers as this is an anarchy client and extra Bossbars are more of a rpg-server thing?

Just count them as bossbars lol.

(atm a ender dragon and a wither named the same will stack)

This is fine in my opinion. The way to go about implementing this is just stacking all boss bars, or separating withers and ender dragons, optionally.

Luna5ama commented 3 years ago

The question is do we care for such servers as this is an anarchy client and extra Bossbars are more of a rpg-server thing?

Just count them as bossbars lol.

We are counting the entity :moyai:

5HT2 commented 3 years ago

The entity might not exist

Luna5ama commented 3 years ago

The entity might not exist

That was his question. We will have to ignore those random ones if we count from entities. And counting from bossbar doesn't work because it doesn't contain the type of boss.

FriedrichM commented 3 years ago

Close pls