search

kami-blue / client

ARCHIVED - KAMI Blue: a continuation of 1.12.2 KAMI
https://kamiblue.org
GNU Lesser General Public License v3.0
362 stars 375 forks source link

enh: Add option to disable all server side light rendering in NoRender #2196

Closed czho closed 3 years ago

czho commented 3 years ago

Describe the pull quick fix for skylight lag

Describe how this pull is helpful It fixes skylight no render not working on the ban machines

5HT2 commented 3 years ago

Well it doesn't look like you've enabled permission for me to push to your pull request, you'll have to do it yourself if you want it merged.

image0

Ideally you should have a method like so, in NoRender

    fun handleLighting(lightType: EnumSkyBlock): Boolean {
        return isEnabled && (skylight && lightType == EnumSkyBlock.SKY || allLightingUpdates)
    }
czho commented 3 years ago

Well it doesn't look like you've enabled permission for me to push to your pull request, you'll have to do it yourself if you want it merged.

image0

Ideally you should have a method like so, in NoRender

    fun handleLighting(lightType: EnumSkyBlock): Boolean {
        return isEnabled && (skylight && lightType == EnumSkyBlock.SKY || allLightingUpdates)
    }

If you wana push ur current changes you can, I fixed the permission thing but if not I will do the changes you asked.