search

kamicane / prime

An essential JavaScript library for node.js and browsers
154 stars 32 forks source link

`object.keys` incorrectly gets the keys of all enumerable properties, instead of just own-enumerable properties. #15

Closed jdalton closed 11 years ago

jdalton commented 11 years ago

The expected behavior of object.keys would be to follow ES5 Object.keys and get the keys of only the own-enumerable properties of an object.

kamicane commented 11 years ago

Closing, as the split-generics branch is now on master. object/keys.js is now allowed to behave in any way we want it to.

jdalton commented 11 years ago

I think you've swung to the other extreme. It just comes down t knowing when-and-when-not to use native methods.