Beef up the `string.trim` fallback

kamicane / prime

An essential JavaScript library for node.js and browsers

154 stars 32 forks source link

Beef up the `string.trim` fallback #18

Closed jdalton closed 11 years ago

jdalton commented 11 years ago

Currently Prime's ES5 String#trim fallback is pretty basic. There are known issues with using a regexp and \s. See ES5Shim's String#string implementation here: kriskowal/es5-shim/es5-shim.js#L899-L918

kamicane commented 11 years ago

Closing, as the split-generics branch is now on master. string/trim.js is now allowed to behave in any way we want it to.