search

kamicane / prime

An essential JavaScript library for node.js and browsers
154 stars 32 forks source link

Change mout dependency to be less restrictive #40

Closed mpj closed 7 years ago

mpj commented 10 years ago

Very helpful when deduping.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling c90866fc08c81c76c86493635754857dc6304a9d on mpj:patch-1 into f0fe4c7766bad52ec2b2cc1664c437f915365784 on kamicane:master.

jdalton commented 10 years ago

Mout is still not v1.0 and introduces breaking changes from release to release. If anything, because it's pre-1.0 you should be more restrictive.

kentaromiura commented 10 years ago

I agree with @jdalton, a "compatible with 0.9" is not a good idea for the reason he has state, also because the "compatible with" is only working on node post >= 0.10 and iirc prime still works fine on previous version of node. This change will make prime incompatible with 0.8 for no apparent reason.

GCheung55 commented 10 years ago

prime is 0.4.x right now. I think it can afford to have breaking changes. That said, it can be more restrictive and test against moutjs@0.10 before updating.

This change will make it incompatible with node.js@0.8 because of the semver ^ correct?

kentaromiura commented 9 years ago

Yep