kamigaito / SLAHAN

SLAHAN is an implementation of Kamigaito et al., 2020, "Syntactically Look-A-Head Attention Network for Sentence Compression", In Proc. of AAAI2020.
MIT License
19 stars 3 forks source link

Is options.hpp missing <float.h>? #7

Open Zachary1575 opened 11 months ago

Zachary1575 commented 11 months ago

When I build, I get the error of:

[  6%] Building CXX object CMakeFiles/slahan.dir/lib/slahan.cpp.o
[ 13%] Building CXX object CMakeFiles/base.dir/lib/base.cpp.o
[ 20%] Building CXX object CMakeFiles/lstm.dir/lib/lstm.cpp.o
[ 26%] Building CXX object CMakeFiles/attn.dir/lib/attn.cpp.o
In file included from In file included from /Users/.../base.cpp::2121:
:
In file included from In file included from /Users/.../SLAHAN/compressor/include/s2s/nn/base.hpp::2323:
:
/Users/.../SLAHAN/compressor/include/s2s/corpus/options.hpp:371/Users/zacharyg/Desktop/SLAHAN/compressor/include/s2s/corpus/options.hpp:371:84: :84: error: use of undeclared identifier 'FLT_MAX'
In file included from /Users/.../SLAHAN/compressor/lib/lstm.cpperror: :21:
use of undeclared identifier 'FLT_MAX'In file included from 
        ("dummy_flt_min", po::value<float>(&(opts->dummy_flt_min))->default_value(-FLT_MAX), "minimum value of the float")
                                                                                   ^/Users/.../SLAHAN/compressor/include/s2s/nn/lstm.hpp:23
:
...

This is resolved by adding #include <float.h> to options.hpp.

...
#include <vector>
#include <string>

#include <float.h>

#include <boost/archive/text_iarchive.hpp>
#include <boost/archive/text_oarchive.hpp>
...

Just wanted to confirm my build is not just incomplete or occurring through a misconfiguration. Note: I am working on MacOS Apple Silicon.