search

kamikat / moshi-jsonapi

JSON API v1.0 Specification in Moshi.
MIT License
156 stars 34 forks source link

Methods to remove data and includes from Document #33

Closed lukesleeman closed 7 years ago

lukesleeman commented 7 years ago

We have found a need to remove data from Document. This adds in remove methods that corrospond to the add methods

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.8%) to 89.718% when pulling ba78a3c73c239fe37b10508af70e37c06e6369ef on lukesleeman:master into 09bf2c3a38de018df4f9be71320104037dba7ec0 on kamikat:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.8%) to 89.718% when pulling ba78a3c73c239fe37b10508af70e37c06e6369ef on lukesleeman:master into 09bf2c3a38de018df4f9be71320104037dba7ec0 on kamikat:master.

kamikat commented 7 years ago

Thanks for PR! Would you please provide some test case for this? or I'll just merge them and write tests to convince code coverage checker.

kamikat commented 7 years ago

Close the issue because we're now working on version 3.0. Thank you.