search

kamikitty / ResilientSmartGarden

0 stars 0 forks source link

Halt server communication attempt when cancel is pressed #21

Closed jasonplojo closed 7 years ago

jasonplojo commented 7 years ago

The thread handling the server communication is still executing when the cancel button is fixed. Make it so the thread stops when the cancel button is pressed.

jasonplojo commented 7 years ago

Looks like it's not a good idea to stop a thread, especially when it's an HTTP request. Best thing to do is make the timeout duration shorter and design around it. This includes hiding the register/login dialog and displaying a "connection" animation, which happens to tie into #20.

jasonplojo commented 7 years ago

Set the timeouts to 3 seconds.

Technically this issue is not fixed, but there is a work around, so this issue will be closed instead of being done.