search

kamilchm / go2nix

Reproducible builds and development environment for Go
MIT License
94 stars 17 forks source link

Add a flag to turn on test imports #1

Closed valeriangalliat closed 8 years ago

valeriangalliat commented 8 years ago

I found myself needing to not include test imports when running go2nix, but the behavior was not configurable via the CLI.

This is a breaking change since the default behavior would now be to not include test imports. Another option would be to have a --no-test-imports flag. What do you think?

kamilchm commented 8 years ago

I'm back after holidays and I'll try to look at all your PRs tommorow.

valeriangalliat commented 8 years ago

Thanks a lot! Also, no hurry. :smile:

Feel free to ping me on Freenode if you have any question / want to discuss about this, my nick is currently val1.

kamilchm commented 8 years ago

I would stick with --test-imports disabled as default, like in godep https://github.com/tools/godep/blame/master/Readme.md#L40