`watch` does not update query results unless a `fetchPolicy` is supplied

[andreialecu]

Describe the bug

This is a pretty weird one. We have a query that we're using .watch() on.

The APIs are generated by graphql-code-generator

We've been troubleshooting a mutation not updating a watched query. After randomly trying things, it appears that what fixed it was setting an explicit fetchPolicy.

Even using the default fetchPolicy seems to work, as long as something is specified. It cannot be undefined.

To Reproduce Steps to reproduce the behavior:

export class GetAppUserClubPermissionsGQL extends Apollo.Query<GetAppUserClubPermissionsQuery, GetAppUserClubPermissionsQueryVariables> {
  // ...
}

// appClubPermissions is of type GetAppUserClubPermissionsGQL

// this works
this.appClubPermissions.watch(
  { clubId },
  { fetchPolicy: "cache-first" }, // also network-only, network-first work
);

// this does NOT trigger observable updates
this.appClubPermissions.watch(
  { clubId },
);

// send a mutation now, and watch how just the first subscription updates

appClubPermissions

Expected behavior

fetchPolicy should be optional, and the query should update by default.

Environment:

• @apollo/client: 3.3.12
• apollo-angular: 2.4.0
• graphql: 15.5.0
• @angular/core: 11.2.5
• @angular/cli: 11.2.5
• typescript: 4.1.0

Additional context

Not sure if relevant, but the type itself defines custom keyFields in the cache, like:

  const cache = new InMemoryCache({
    typePolicies: {
      AppUserPermissions: {
        keyFields: ['email'],
      },
    },
  });

[andreialecu]

Nevermind, the problem was that this project had configured no-cache as the default cache policy:

  const defaultOptions = {
    watchQuery: {
      fetchPolicy: 'no-cache',
      errorPolicy: 'ignore',
    },
    query: {
      fetchPolicy: 'no-cache',
      errorPolicy: 'all',
    },
  };