Closed PowerKiKi closed 1 year ago
Latest commit: 295ef5ccba9bfbc6b294a00f807898bdf98f1562
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Hi there!
I noticed that you seem to be missing all the Angular version updates in your dependencies:
"@angular-devkit/build-angular": "^16.0.0",
"@angular-devkit/core": "^16.0.0",
"@angular-devkit/schematics": "^16.0.0",
"@angular/animations": "^16.0.0",
"@angular/cli": "^16.0.0",
"@angular/common": "^16.0.0",
"@angular/compiler": "^16.0.0",
"@angular/compiler-cli": "^16.0.0",
"@angular/core": "^16.0.0",
"@angular/platform-browser": "^16.0.0",
"@angular/platform-browser-dynamic": "^16.0.0",
"@angular/platform-server": "^16.0.0",
"@angular/router": "^16.0.0",
"ng-packagr": "^16.0.0",
"@schematics/angular": "^16.0.0",
However, there is currently one dependency missing Angular 16 compatibility: jest-preset-angular. There's a merge request (thymikee/jest-preset-angular#2061) addressing this issue.
Once that's resolved, your attempt to upgrade to Angular 16 should be more comprehensive.
Yeap, this was not meant to be merged as is, but only to see how much would break. Doesn't look too bad so far, but indeed updating our deps is required before merging.
Great news! jest-preset-angular has been released with version 13.1.0, which is now compatible with Angular 16. With this update, it looks like your dependencies are all set and ready for a successful upgrade to Angular 16.
I added a PR to fix some low-hanging fruits and removed a test that tested a removed usecase here: https://github.com/kamilkisiela/apollo-angular/pull/2010
Superseded by #2010
Checklist: