kamilkisiela / apollo-client-rxjs

Adds RxJS to ApolloClient
http://apollostack.com
44 stars 12 forks source link

feat(rxjs): added support for rxjs@5.5.0-beta.0 #54

Closed CaerusKaru closed 6 years ago

CaerusKaru commented 6 years ago
CaerusKaru commented 6 years ago

@kamilkisiela This package should be able to be updated (with the exception of the tests that are failing for the moment) before angular. apollo-client and apollo-angular will have to wait though.

kamilkisiela commented 6 years ago

Those changes are not backwards compatible so it'll break any other library that depends on it. Once apollo-angular and angular itself will be ready for rxjs@5.5.0, then I'll start updating everything from root, apollo-client-rxjs.

CaerusKaru commented 6 years ago

True, but the PR can stay here or be merged into another branch until it's ready

CaerusKaru commented 6 years ago

@kamilkisiela I didn't realize how much of apollo-client-rxjs is tied up in apollo-client's Observable implementation. This PR is pretty much useless until it gets sorted out higher up, so I'm closing it for now. Hopefully they can resolve these issues soon ¯/_(ツ)_/¯