search

kamilkisiela / bob

Build tool used in libraries maintained by The Guild
48 stars 12 forks source link

check node engine is provided in package.json #248

Closed n1ru4l closed 1 year ago

n1ru4l commented 1 year ago

Closes https://github.com/kamilkisiela/bob/issues/246

I am still not 100% sure whether we should ensure this - as people could also be building browser-only packages. 🤔 Right now the bob check command assumes the files are loadable by Node.js anyways. 🤔

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 71355bf2f8b76fe113ff4c887ef39be78128c992

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | bob-the-bundler | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR