kamilkisiela / graphql-inspector

🕵️‍♀️ Validate schema, get schema change notifications, validate operations, find breaking changes, look for similar types, schema coverage
https://the-guild.dev/graphql/inspector
MIT License
1.65k stars 185 forks source link

Coverage stats does not calculate queries, mutations and subscriptions. #2717

Open osolomin90 opened 5 months ago

osolomin90 commented 5 months ago

Issue workflow progress

Progress of the issue based on the Contributor Workflow


Describe the bug

Coverage calculates only root types of queries, mutations and subscriptions when should calculate fields of those root types.

Screenshot 2024-04-26 at 18 19 00

To Reproduce Steps to reproduce the behavior:

Schema:

Screenshot 2024-04-26 at 18 20 52

Root of issue:

Screenshot 2024-04-26 at 18 16 31

Expected result: Each mutation inside Mutation type should be counted.

Environment:

Additional context

TuvalSimha commented 5 months ago

Hey @osolomin90, thank you for this issue! Any chance you want to try fix it?

osolomin90 commented 5 months ago

Hey @osolomin90, thank you for this issue! Any chance you want to try fix it?

@TuvalSimha I want, but I am not sure if I will have time to sit and solve it...

osolomin90 commented 5 months ago

Hey @osolomin90, thank you for this issue! Any chance you want to try fix it?

@TuvalSimha Hey, I tried to fix it) https://github.com/kamilkisiela/graphql-inspector/pull/2731

TuvalSimha commented 4 months ago

Hey @osolomin90 thank you very much! i will take a look soon and update as well!

DanteUkraine commented 4 months ago

@TuvalSimha, I was wondering which release will include stats changes?