kamilkp / angular-vs-repeat

Virtual Scroll for AngularJS ngRepeat directive
http://kamilkp.github.io/angular-vs-repeat/
MIT License
818 stars 228 forks source link

double question marks raising syntax error in the 2.0.6 #190

Closed Liooo closed 6 years ago

Liooo commented 6 years ago

for example on this line https://github.com/kamilkp/angular-vs-repeat/blob/master/src/angular-vs-repeat.js#L95

Other lines have ?? as well, is this a valid js syntax that I don't know, or you were just back from C# or something?

kamilkp commented 6 years ago

It is valid but currently only with babel. https://github.com/tc39/proposal-nullish-coalescing

Liooo commented 6 years ago

oh didn't know that thanks, then I think it's bower.json's problem. main entity should be dist/angular-vs-repeat.min.js instead of src/angular-vs-repeat.js. even latest stable chrome doesn't accept ?? syntax yet, so.

kamilkp commented 6 years ago

Yeah, it’s a problem with bower.json indeed.

Kamil Pękala

Wiadomość napisana przez Ryo Yamada notifications@github.com w dniu 19.03.2018, o godz. 14:15:

oh didn't know that thanks, then I think it's bower.json's problem. main entity should be dist/angular-vs-repeat.min.js instead of src/angular-vs-repeat.js. even latest stable chrome doesn't accept ?? syntax yet, so.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.