search

kamilpacaq / drydock

Automatically exported from code.google.com/p/drydock
0 stars 0 forks source link

Image deletion does not always work (rmdir) #22

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Warning: rmdir(/home/thisismywobsite/images/####/) [function.rmdir]:
Directory not empty in /home/thisismywobsite/common.php on line 308

Original issue reported on code.google.com by TaQS...@gmail.com on 22 Sep 2008 at 5:41

GoogleCodeExporter commented 8 years ago 
And sometimes this happens also

Warning: implode() [function.implode]: Invalid arguments passed in
/home/thisismywobsite/dbi/MySQL.php on line 802

Original comment by TaQS...@gmail.com on 22 Sep 2008 at 5:43

GoogleCodeExporter commented 8 years ago

Original comment by all.sta...@gmail.com on 9 Dec 2008 at 10:23

GoogleCodeExporter commented 8 years ago 
It could be hackish but you know, you could just check if the rmdir call fails, 
and
if it does, try to clean out the directory.

I don't know about the second part though.

Original comment by all.sta...@gmail.com on 9 Dec 2008 at 10:37

GoogleCodeExporter commented 8 years ago 
Yeah it happens so rarely that debugging it is going to be an issue that I am 
not
sure how to tackle.  We could just start logging all of those actions along 
with any
returned errors and what it was actually doing.  At least then there will be a 
record
of it.

Original comment by TaQS...@gmail.com on 9 Dec 2008 at 6:40

GoogleCodeExporter commented 8 years ago 
I guess we can stick it under administrative tasks in housekeeping.  Call it 
like
"image audit" or something.

Original comment by TaQS...@gmail.com on 18 Dec 2008 at 8:52

GoogleCodeExporter commented 8 years ago 
So, actually keeping track of the images that didn't get successfully deleted 
is a
workaround for this for now.  Long-term it'd be nice to have the orphaned images
deleter, but right now logging the failed deletes to the "rmfailures" log 
should be
good enough.  And since it logs the error message as well, this should help for
debugging.

And what do you know, I might have fixed this anyway, but I have no idea.  I did
rework how it filters out images to delete.  Now, instead of skipping over any 
files
that start with ".", it'll only skip over "." and ".." for unlink calls.  I 
don't
know if that was the cause, but you never know.

Anyway, the necessary changes were applied to delimgs in revision 166:
http://code.google.com/p/drydock/source/detail?r=166

Original comment by all.sta...@gmail.com on 24 Aug 2009 at 2:34