issues
search
kamilsk
/
semaphore
🚦 Semaphore pattern implementation with timeout of lock/unlock operations.
MIT License
103
stars
12
forks
source link
goroutine leak
#133
Open
kamilsk
opened
6 years ago
kamilsk
commented
6 years ago
[ ]
https://github.com/kamilsk/semaphore/blob/master/channel.go#L42-L46
[ ]
https://github.com/kamilsk/semaphore/blob/master/context.go#L11-L12
[ ]
https://github.com/kamilsk/semaphore/blob/master/channel.go#L52-L63
- channel + cancel, because
time.After
is bad
[ ]
https://github.com/kamilsk/semaphore/blob/master/channel.go#L35-L49
- the same as above, because we don't need to listen signal when work is done
[ ] investigate more
kamilsk
commented
6 years ago
https://go101.org/article/concurrent-common-mistakes.html
time.After
is bad